Make get_best_tx_ids_by_score_and_ancestry non-recursive#2070
Merged
Conversation
…'t overflow a small stack; appease clippy.
ImplOfAnImpl
force-pushed
the
make_tx_ids_by_score_non_recursive
branch
from
7717d7a to
e029b8c
Compare
OBorce
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_best_tx_ids_by_score_and_ancestryis no longer recursive. Due to the cluster limits being introduced in #2063, this is no longer that important, because with the default cluster limits the max depth of the recursion will be small. But the non-recursive version still makes a bit of sense, as it prevents a mis-configured node from crashing.P.S. I had to bump the min Rust version, because an std function I use (
btree_map::Entry::insert_entry) requires Rust 1.92.